Talk:Go Fish/Go
Not idiomatic
This is not an idiomatic or good example of Go code.
See Effective Go and the Go Authors code review comments page to start.
For example:
- Identifier names should not have underscores and no leading underscores. Names like
kFoo
andtBar
are also non-idiomatic. - Function/method comments are usually in
//
rather than/* */
. They shouldn't be wrapped so short and they should be written for reasonable godoc parsing (e.g. start with a summary sentence that starts with the name of the function/method/type). - Receiver names should not be
self
,this
, orme
- …
The overall structure and quality of this example is also sub-par.