Jump to content

Talk:Go Fish/Go

From Rosetta Code

Not idiomatic

This is not an idiomatic or good example of Go code.

See Effective Go and the Go Authors code review comments page to start.

For example:

  • Identifier names should not have underscores and no leading underscores. Names like kFoo and tBar are also non-idiomatic.
  • Function/method comments are usually in // rather than /* */. They shouldn't be wrapped so short and they should be written for reasonable godoc parsing (e.g. start with a summary sentence that starts with the name of the function/method/type).
  • Receiver names should not be self, this, or me

The overall structure and quality of this example is also sub-par.

dchapes (talk | contribs) 18:45, 22 February 2015 (UTC)

It's been refactored on two separate occasions since this was posted. How do you feel about it now?

Joshua.Snider (talk) 05:21, 12 September 2015 (UTC)

Cookies help us deliver our services. By using our services, you agree to our use of cookies.