Talk:Constrained random points on a circle

From Rosetta Code
Revision as of 21:39, 3 September 2010 by rosettacode>Mwn3d (→‎Disappearing code?: it doesnt look like it was ever there.)

Not 100 points

There are only 89 points in the circle shown in the verilog example output. This is no surprise, because AFAICS the algorithm doesn't make sure that the same point isn't chosen twice. Now given that it's the first example, I guess it's what was meant by the task description, but then the task description probably should be changed to reflect the fact that less points are OK. --Ce 10:55, 3 September 2010 (UTC)

I've fixed the description: it would be a poor RNG that doesn't produce duplicates --Dave

You could have a good RNG and yet get exactly 100 points by simply checking for duplicates and continuing until you have 100 points (or alternatively, make a list of all points, random-shuffle it, and take the first 100 items from the resulting list).
BTW, the revised description isn't quite right: The points don't overlap; you get the same point several times. --Ce 16:31, 3 September 2010 (UTC)

How to check the code

If you increase the number of points produced to 10k, you should get output rather like this (generated with Tcl version; your version may differ). This lets you check that the spread of points produces the expected annulus. –Donal Fellows 11:00, 3 September 2010 (UTC)

               X               
          XXXXXXXXXXX          
        XXXXXXXXXXXXXXX        
      XXXXXXXXXXXXXXXXXXX      
     XXXXXXXXXXXXXXXXXXXXX     
    XXXXXXXXXXXXXXXXXXXXXXX    
   XXXXXXXX         XXXXXXXX   
   XXXXXXX           XXXXXXX   
  XXXXXX               XXXXXX  
  XXXXXX               XXXXXX  
 XXXXXX                 XXXXXX 
 XXXXX                   XXXXX 
 XXXXX                   XXXXX 
 XXXXX                   XXXXX 
 XXXXX                   XXXXX 
XXXXXX                   XXXXXX
 XXXXX                   XXXXX 
 XXXXX                   XXXXX 
 XXXXX                   XXXXX 
 XXXXX                   XXXXX 
 XXXXXX                 XXXXXX 
  XXXXXX               XXXXXX  
  XXXXXX               XXXXXX  
   XXXXXXX           XXXXXXX   
   XXXXXXXX         XXXXXXXX   
    XXXXXXXXXXXXXXXXXXXXXXX    
     XXXXXXXXXXXXXXXXXXXXX     
      XXXXXXXXXXXXXXXXXXX      
        XXXXXXXXXXXXXXX        
          XXXXXXXXXXX          
               X               

Uniform distribution

I'm not very good with stats, but I've seen discussions pop up before about different distributions of points. Is uniform vs normal vs (something?) a significant component of the task? How may it be verified with at most 100 points? --Michael Mol 12:27, 3 September 2010 (UTC)

I guess that if you count the number of points that lie on a line that passes through the center, then the count should not depend on the angle of that line. So it would be wrong to simply pick a uniform-random value of x and then a uniform-random of y at that location, because that would tend to lead to a higher density of points on the left and right sides (look at the maximally dense version above: there are 12 possible values of y at x==0; but only one at x == +/- 15) -- and thus a greater number of points away from the x-axis. A common mistake when generating a set of linked random variables is that the distribution depends on the order in which they are generated.

So, take this Perl code:

my @bitmap = map { " " x 32 } 0 .. 33;
for (1 .. 100) {
    my $x = int rand(31) - 15;


    my $max = sqrt( 225-($x*$x) );
    my $min = 100-($x*$x);
    $min = $min > 0 ? sqrt $min : 0;

    my $y = int rand( 1+$max-$min ) + $min;
    $y = -$y if rand() < .5;


    $x += 16;
    $y += 16;
    #print "$x $y\n";
    substr( $bitmap[$y], $x, 1, "#" );
}

print "$_\n" for @bitmap;


               # #
          #    ##    #
       #   ## ##  ##   #
      #        ##  #   #
         # # # #   #  # #
      #           # #
        ##          #   #
        #
  #                      #
     #                       #
 ## #                    #
  #
 #
                           #
 ## #                         #
  #                        #
    ##                      #

                             #
 #                      #

       #                #  #
   #     #
        ## #      # #
        #     #   #
     #  # #       ##  #
        # #  #      ##
            #       #
             # #

Here you can see that the number of points near top/bottom is greater than that for left/right sides of the plot. For this particular case, the simplest way to check for the bias is to count the number of points where abs(y) > abs(x) (this effectively partitions the plot using 45 degree lines) -- for my "bad" code I see a ratio (over multiple runs) of 54:46 in favor of the top/bottom quadrants over left/right. Counted another way, 79% of random seeds result in a plot with more top/bottom points than left/right. -Dave

An example of a more subtle error is to pick the random point using a polar coordinate system (i.e., using a random distance over the given range and a random angle). The problem is that the distribution of random points is not even w.r.t. area when picked that way; points that are closer in will be more tightly packed. It becomes much more noticeable with a wider annulus. –Donal Fellows 15:07, 3 September 2010 (UTC)
Using a polar coordinate system isn't by itself an error. Using an uniform distribution for the radial coordinate is, however. --Ce 16:34, 3 September 2010 (UTC)
theta=rand() should be fine, but I'm having a mental block figuring out what to multiply r by to fix its distribution. atan(r)? --Michael Mol 18:02, 3 September 2010 (UTC)
Since and , I'd say should be evenly distributed between and , and you then of course get by taking the square root. However note that this is basically a brain dump. --Ce 19:16, 3 September 2010 (UTC)

Disappearing code?

I remember writing and posting a J implementation, and yet I do not see it in the history for the page. Does anyone know what is up with that? (Does history get lost if someone undoes an edit and then edits forward from that point?) Anyways, I will re-implement it, it was simple enough. But I am bothered by the absence of history. --Rdm 18:04, 3 September 2010 (UTC)

If someone undid an edit an undo would show up in the page history and your edit would still be there. It doesn't seem to be in the history so unless someone did a rollback (which I don't think I've seen done for any page) or deleted the page and re-created it your edit would be there. --Mwn3d 21:39, 3 September 2010 (UTC)