Talk:Longest string challenge: Difference between revisions

Line 385:

}</lang> --[[User:Ledrug|Ledrug]] 21:45, 17 August 2011 (UTC)

::::::: Bytes from <code>bufend</code> on were not "resources" they were "protection". So no, I do not agree that it's a correctness issue. If that's a correctness issue, you might as well argue that a program is incorrect because some memory on the heap has not been allocated. Your ACCU_MAX is the moral equivalent of my <code>bufend</code>. I could agree to calling this an efficiency issue, but not a correctness issue. --[[User:Rdm|Rdm]] 22:23, 17 August 2011 (UTC)

:::: (deindent) Ok I guess that's what's confusing about the code. You could check available buffer at a more natural place: <code>next+1</code>. That's where you'd copy the line string to to begin with:<lang c> char line[LINE_MAX] = {0};

char buf[ACCU_MAX] = {0};

char *last = buf;

char *next = buf;

while (fgets(line, LINE_MAX, stdin)) {

if (line[LINE_MAX - 2]) exit(1);

if (longer(last, line)) continue;

if (longer(line, last)) {

memset(buf, 1, ACCU_MAX);

buf[0] = buf[ACCU_MAX - 1] = 0;

next = buf;

}

if (*line && longer(&line[1], &next[1])) exit(1);

strcpy(next, line);

for (last = next; *next; next = &next[1]);

}</lang> (I didn't define the LINE_MAX and ACCU_MAX just to be different, it's easier to change the values for testing. They ''are'' related to your <code>bufend</code>). There's still one issue: <code>echo -n "a\naa\naaa"|./a.out</code> fails, which has nothing to do with the modifications I made. --[[User:Ledrug|Ledrug]] 23:10, 17 August 2011 (UTC)

== Boring solution v. restrictions ==