User talk:Dijkstra

From Rosetta Code
Revision as of 20:52, 27 July 2018 by Thundergnat (talk | contribs) (→‎Text processing/Max licenses in use: Parametrized SQL statement comments were appropriate though.)

Considered harmful

While you may not agree with the coding style of a particular entry, just labeling it "Considered Harmful" is not very productive. Pointing out obvious flaws (with some level of detail) is great. Vague, dismissive commentary based on some unstated standard of code "quality" is not so much. It would be more useful to add something on the task discussion page with concerns/observations about the examples. --Thundergnat (talk) 18:25, 5 July 2018 (UTC)

Text processing/Max licenses in use

Please avoid removing perfectly valid mark-up from entries for no reason. There is no bad assumption of a (third party) licensing daemon. The task description specifically states that there is a licensing daemon that faithfully records in and out events. The log file given has only license in and out events, no comments, no blank lines. One of the entries that you marked as incorrect is in fact by the task author who provided the log file, presumably knew what he was trying to accomplish and considered the appropriate constraints. Marking multiple different language entries {{incorrect|Python|whatever}} is not very useful. Mark each different language with it's own name. If you disagree with the task constraints and requirements, take it up on the talk page. --Thundergnat (talk) 20:43, 27 July 2018 (UTC)

On the other hand, your comments on the Parametrized SQL statement task were pretty appropriate. Again, some unnecessary edits to white space, but the comments were valid (and the correct language names used in the "incorrect" tags).--Thundergnat (talk) 20:51, 27 July 2018 (UTC)