Pythagorean triples/Java/Brute force primitives: Difference between revisions

From Rosetta Code
Content added Content deleted
m (It turns out that the GCD check can speed it up a little bit)
m (With the GCD check we can be sure that we have found a primitive, so we can mark them (negligible speed change))
Line 1: Line 1:
{{works with|Java|1.5+}}
{{works with|Java|1.5+}}
This version brute forces primitive triple candidates and then scales them to find the rest (under the perimeter limit of course). Since it only finds the primitives mathematically it can optimize its candidates based on some of the properties [[wp:Pythagorean_triple#Elementary_properties_of_primitive_Pythagorean_triples|here]] -- namely that a and b have opposite evenness, only one of a and b is divisible by 3, only one of a and b is divisible by 4, c is always odd, and that a<sup>2</sup> + b<sup>2</sup> must be a perfect square (which [[wp:Square_number#Properties|don't ever end in 2, 3, 7, or 8]]). After using those rules to eliminate candidates for a,b pairs, it checks that a and b are coprime. Since many a,b pair candidates have already been eliminated, this check actually speeds things up a little bit by letting the program skip some c loops. For a perimeter limit of 1000, it is about 5 times faster than [[Pythagorean triples#Java|the other brute force version]]. For a perimeter limit of 10000, it is about 17 times faster. It also does not mark the primitives.
This version brute forces primitive triple candidates and then scales them to find the rest (under the perimeter limit of course). Since it only finds the primitives mathematically it can optimize its candidates based on some of the properties [[wp:Pythagorean_triple#Elementary_properties_of_primitive_Pythagorean_triples|here]] -- namely that a and b have opposite evenness, only one of a and b is divisible by 3, only one of a and b is divisible by 4, c is always odd, and that a<sup>2</sup> + b<sup>2</sup> must be a perfect square (which [[wp:Square_number#Properties|don't ever end in 2, 3, 7, or 8]]). After using those rules to eliminate candidates for a,b pairs, it checks that a and b are coprime. Since many a,b pair candidates have already been eliminated, this check actually speeds things up a little bit by letting the program skip some c loops. For a perimeter limit of 1000, it is about 5 times faster than [[Pythagorean triples#Java|the other brute force version]]. For a perimeter limit of 10000, it is about 17 times faster. It also marks the primitives.


It defines a <code>Triple</code> class which is comparable so it can be placed in a <code>TreeSet</code> for easy sorting and to remove duplicates (the GCD check should remove duplicates, but it's nice to make sure). It also can scale itself by an integer factor.
It defines a <code>Triple</code> class which is comparable so it can be placed in a <code>TreeSet</code> for easy sorting and to remove duplicates (the GCD check should remove duplicates, but it's nice to make sure). It also can scale itself by an integer factor.
Line 23: Line 23:
private static BigInteger LIMIT = BigInteger.valueOf(100);
private static BigInteger LIMIT = BigInteger.valueOf(100);
public static class Triple implements Comparable<Triple>{
public static class Triple implements Comparable<Triple>{
BigInteger a, b, c, peri;
BigInteger a, b, c, peri;
boolean prim;

public Triple(BigInteger a, BigInteger b, BigInteger c, boolean prim) {
this.a = a;
this.b = b;
this.c = c;
peri = a.add(b).add(c);
this.prim = prim;
}
public Triple scale(long k){
return new Triple(a.multiply(BigInteger.valueOf(k)),
b.multiply(BigInteger.valueOf(k)),
c.multiply(BigInteger.valueOf(k)),
prim && k == 1);
}

@Override
public boolean equals(Object obj) {
if(obj.getClass() != this.getClass()) return false;
Triple trip = (Triple)obj;
return a.equals(trip.a) && b.equals(trip.b) && c.equals(trip.c);
}

@Override
public int compareTo(Triple o) {
if(!a.equals(o.a)) return a.compareTo(o.a);
if(!b.equals(o.b)) return b.compareTo(o.b);
if(!c.equals(o.c)) return c.compareTo(o.c);
return 0;
}
public String toString(){
return a + ", " + b + ", " + c + (prim ? " primitive" : "");
}
}
private static Set<Triple> trips = new TreeSet<Triple>();
public static void addAllScales(Triple trip){
long k = 2;
Triple tripCopy = trip.scale(k++);
while(tripCopy.peri.compareTo(LIMIT) <= 0){
trips.add(tripCopy);
tripCopy = trip.scale(k++);
}
}
public static void main(String[] args){
public Triple(BigInteger a, BigInteger b, BigInteger c) {
this.a = a;
long primCount = 0;
this.b = b;
long start = System.currentTimeMillis();
this.c = c;
peri = a.add(b).add(c);
}
public Triple scale(long k){
return new Triple(a.multiply(BigInteger.valueOf(k)),
b.multiply(BigInteger.valueOf(k)),
c.multiply(BigInteger.valueOf(k)));
}
@Override
public boolean equals(Object obj) {
if(obj.getClass() != this.getClass()) return false;
Triple trip = (Triple)obj;
return a.equals(trip.a) && b.equals(trip.b) && c.equals(trip.c);
}
@Override
public int compareTo(Triple o) {
//sort by a, then b, then c
if(!a.equals(o.a)) return a.compareTo(o.a);
if(!b.equals(o.b)) return b.compareTo(o.b);
if(!c.equals(o.c)) return c.compareTo(o.c);
return 0;
}
@Override
public String toString(){
return a + ", " + b + ", " + c;
}
}
private static Set<Triple> trips = new TreeSet<Triple>();
public static void addAllScales(Triple trip){
long k = 2;
Triple tripCopy = new Triple(trip.a, trip.b, trip.c);
while(tripCopy.peri.compareTo(LIMIT) < 0){
trips.add(tripCopy);
tripCopy = trip.scale(k++);
}
}
public static void main(String[] args){
long primCount = 0;

BigInteger peri2 = LIMIT.divide(TWO),
BigInteger peri2 = LIMIT.divide(TWO),
peri3 = LIMIT.divide(B3);
peri3 = LIMIT.divide(B3);

for(BigInteger a = B3; a.compareTo(peri3) < 0; a = a.add(ONE)){
for(BigInteger a = B3; a.compareTo(peri3) < 0; a = a.add(ONE)){
BigInteger aa = a.multiply(a);
BigInteger aa = a.multiply(a);
boolean amod3 = a.mod(B3).equals(ZERO);
boolean amod3 = a.mod(B3).equals(ZERO);
boolean amod4 = a.mod(B4).equals(ZERO);
boolean amod4 = a.mod(B4).equals(ZERO);

//b is the opposite evenness of a so increment by 2
//b is the opposite evenness of a so increment by 2
for(BigInteger b = a.add(ONE);
for(BigInteger b = a.add(ONE);
b.compareTo(peri2) < 0; b = b.add(TWO)){
b.compareTo(peri2) < 0; b = b.add(TWO)){
//skip if both or neither of a and b are divisible by each of 3 and 4
//skip if both or neither of a and b are divisible by 3 and 4
if(amod3 == b.mod(B3).equals(ZERO) ||
if(amod3 == b.mod(B3).equals(ZERO) ||
amod4 == b.mod(B4).equals(ZERO)) continue;
amod4 == b.mod(B4).equals(ZERO)) continue;
//if a^2 + b^2 is not a perfect square then don't even test for c's
//if a^2 + b^2 is not a perfect square then don't even test for c's
BigInteger aabb = aa.add(b.multiply(b));
BigInteger aabb = aa.add(b.multiply(b));
Line 96: Line 99:
if(!a.gcd(b).equals(ONE)) continue;
if(!a.gcd(b).equals(ONE)) continue;
BigInteger ab = a.add(b);
BigInteger ab = a.add(b);
//c is always odd for primitives so if b is odd start at b+2 otherwise b+1
for(BigInteger c = b.add(b.testBit(0)? ZERO:ONE);
c.compareTo(peri2) < 0; c = c.add(TWO)){


for(BigInteger c = b.add(b.testBit(0) ? TWO:ONE);
c.compareTo(peri2) < 0; c = c.add(TWO)){
//if a+b+c > periLimit
//if a+b+c > periLimit
if(ab.add(c).compareTo(LIMIT) > 0){
if(ab.add(c).compareTo(LIMIT) > 0){
break;
break;
}
}

int compare = aabb.compareTo(c.multiply(c));
int compare = aabb.compareTo(c.multiply(c));
//if a^2 + b^2 != c^2
//if a^2 + b^2 != c^2
Line 109: Line 114:
break;
break;
}else if (compare == 0){
}else if (compare == 0){
Triple prim = new Triple(a, b, c);
Triple prim = new Triple(a, b, c, true);
if(trips.add(prim)){ //if it's new
if(trips.add(prim)){ //if it's new
primCount++; //count it
primCount++; //count it

Revision as of 18:37, 20 December 2011

Works with: Java version 1.5+

This version brute forces primitive triple candidates and then scales them to find the rest (under the perimeter limit of course). Since it only finds the primitives mathematically it can optimize its candidates based on some of the properties here -- namely that a and b have opposite evenness, only one of a and b is divisible by 3, only one of a and b is divisible by 4, c is always odd, and that a2 + b2 must be a perfect square (which don't ever end in 2, 3, 7, or 8). After using those rules to eliminate candidates for a,b pairs, it checks that a and b are coprime. Since many a,b pair candidates have already been eliminated, this check actually speeds things up a little bit by letting the program skip some c loops. For a perimeter limit of 1000, it is about 5 times faster than the other brute force version. For a perimeter limit of 10000, it is about 17 times faster. It also marks the primitives.

It defines a Triple class which is comparable so it can be placed in a TreeSet for easy sorting and to remove duplicates (the GCD check should remove duplicates, but it's nice to make sure). It also can scale itself by an integer factor.

Note: this implementation also keeps all triples in memory. Be mindful of large perimeter limits. <lang java5>import java.math.BigInteger; import java.util.Set; import java.util.TreeSet;

import static java.math.BigInteger.*;

public class PythTrip{

     public static final BigInteger TWO = BigInteger.valueOf(2),

B3 = BigInteger.valueOf(3), B4 = BigInteger.valueOf(4),

                                    B7 = BigInteger.valueOf(7),  //used for checking primitive properties

B12 = BigInteger.valueOf(12),

                                    B31 = BigInteger.valueOf(31),
                                    B127 = BigInteger.valueOf(127),
                                    B191 = BigInteger.valueOf(191);
     //change this to whatever perimeter limit you want;the RAM's the limit
     private static BigInteger LIMIT = BigInteger.valueOf(100);
    

public static class Triple implements Comparable<Triple>{ BigInteger a, b, c, peri; boolean prim;

public Triple(BigInteger a, BigInteger b, BigInteger c, boolean prim) { this.a = a; this.b = b; this.c = c; peri = a.add(b).add(c); this.prim = prim; }

public Triple scale(long k){ return new Triple(a.multiply(BigInteger.valueOf(k)), b.multiply(BigInteger.valueOf(k)), c.multiply(BigInteger.valueOf(k)), prim && k == 1); }

@Override public boolean equals(Object obj) { if(obj.getClass() != this.getClass()) return false; Triple trip = (Triple)obj; return a.equals(trip.a) && b.equals(trip.b) && c.equals(trip.c); }

@Override public int compareTo(Triple o) { if(!a.equals(o.a)) return a.compareTo(o.a); if(!b.equals(o.b)) return b.compareTo(o.b); if(!c.equals(o.c)) return c.compareTo(o.c); return 0; }

public String toString(){ return a + ", " + b + ", " + c + (prim ? " primitive" : ""); } }

private static Set<Triple> trips = new TreeSet<Triple>();

public static void addAllScales(Triple trip){ long k = 2; Triple tripCopy = trip.scale(k++); while(tripCopy.peri.compareTo(LIMIT) <= 0){ trips.add(tripCopy); tripCopy = trip.scale(k++); } }

   public static void main(String[] args){
       long primCount = 0;
       long start = System.currentTimeMillis();

       BigInteger peri2 = LIMIT.divide(TWO),
               peri3 = LIMIT.divide(B3);

       for(BigInteger a = B3; a.compareTo(peri3) < 0; a = a.add(ONE)){
           BigInteger aa = a.multiply(a);
           boolean amod3 = a.mod(B3).equals(ZERO);
           boolean amod4 = a.mod(B4).equals(ZERO);

           //b is the opposite evenness of a so increment by 2
           for(BigInteger b = a.add(ONE);
                   b.compareTo(peri2) < 0; b = b.add(TWO)){
           	//skip if both or neither of a and b are divisible by 3 and 4
           	if(amod3 == b.mod(B3).equals(ZERO) ||
           		amod4 == b.mod(B4).equals(ZERO)) continue;
               //if a^2 + b^2 is not a perfect square then don't even test for c's
               BigInteger aabb = aa.add(b.multiply(b));
               if((aabb.and(B7).intValue() != 1) && 
                  (aabb.and(B31).intValue() != 4) && 
                  (aabb.and(B127).intValue() != 16) && 
                  (aabb.and(B191).intValue() != 0)) continue;
               if(!a.gcd(b).equals(ONE)) continue;
               BigInteger ab = a.add(b);
               
               //c is always odd for primitives so if b is odd start at b+2 otherwise b+1
               for(BigInteger c = b.add(b.testBit(0)? ZERO:ONE);
                       c.compareTo(peri2) < 0; c = c.add(TWO)){
                   //if a+b+c > periLimit
                   if(ab.add(c).compareTo(LIMIT) > 0){
                       break;
                   }
                   
                   int compare = aabb.compareTo(c.multiply(c));
                   //if a^2 + b^2 != c^2
                   if(compare < 0){
                       break;
                   }else if (compare == 0){
                       Triple prim = new Triple(a, b, c, true);
                       if(trips.add(prim)){    //if it's new
                           primCount++;        //count it
                           addAllScales(prim); //add its scales
                       }
                   }
               }
           }
       }
       for(Triple trip:trips){
           System.out.println(trip);
       }
       System.out.println("Up to a perimeter of " + LIMIT + ", there are "
               + trips.size() + " triples, of which " + primCount + " are primitive.");
   }

}</lang> Output:

3, 4, 5
5, 12, 13
6, 8, 10
7, 24, 25
8, 15, 17
9, 12, 15
9, 40, 41
10, 24, 26
12, 16, 20
12, 35, 37
15, 20, 25
15, 36, 39
16, 30, 34
18, 24, 30
20, 21, 29
21, 28, 35
24, 32, 40
Up to a perimeter of 100, there are 17 triples, of which 7 are primitive.